Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to configure ephemeral storage size #71

Merged
merged 4 commits into from
May 11, 2022
Merged

Add ability to configure ephemeral storage size #71

merged 4 commits into from
May 11, 2022

Conversation

bakerkretzmar
Copy link
Contributor

@bakerkretzmar bakerkretzmar commented May 10, 2022

Adds a storage method and config option to allow configuring a Lambda's ephemeral storage.

Tested in my own AWS account and AWS appears to completely ignore the parameter.... will keep fiddling with it works like a charm.

Closes #70.

@aarondfrancis
Copy link
Owner

Hmm I wonder why it's just being ignored, I don't see anything obvious here that's missing! I'll dig into the API docs a bit more to see if I can find anything subtle.

@bakerkretzmar
Copy link
Contributor Author

Yeah this is really frustrating 😅 I tried configuring Sidecar again from scratch, tried a different region, tried all kinds of weird combinations of EphemeralStorage and Size as parameters, can't seem to get it to even recognize that I'm sending it in.

@bakerkretzmar
Copy link
Contributor Author

Works with the aws CLI too.

@aarondfrancis
Copy link
Owner

What version is the AWS SDK on? Maybe we need to bump the minimum to 3.216.1?

@bakerkretzmar
Copy link
Contributor Author

Ouf my bad @aarondfrancis the app I'm in was using a weird wrapper around the AWS PHP package and the underlying version was 4 months old. Updated and this works perfectly!

@bakerkretzmar bakerkretzmar marked this pull request as ready for review May 11, 2022 15:04
@aarondfrancis
Copy link
Owner

Nah no worries, that was definitely not my first guess.

@aarondfrancis aarondfrancis merged commit a630b39 into aarondfrancis:main May 11, 2022
@aarondfrancis
Copy link
Owner

Lovely, thank you for doing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to configure ephemeral storage
2 participants