Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: Removing unsupported runtimes #90

Merged
merged 4 commits into from
Feb 28, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions docs/overview.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,18 +10,13 @@ You can write functions in any of the following runtimes and execute them straig
- Node.js 16
- Node.js 14
- Node.js 12
- Node.js 10
- Python 3.8
- Python 3.7
- Python 3.6
- Python 2.7
- Ruby 2.7
- Ruby 2.5
- Java 11
- Java 8
- Go 1.x
- .NET Core 3.1
- .NET Core 2.1

Any runtime that [Lambda supports](https://docs.aws.amazon.com/lambda/latest/dg/lambda-runtimes.html), you can use!

Expand Down Expand Up @@ -128,4 +123,4 @@ If you need other services, you are encouraged to use the instances that Vapor h
**Sidecar does not provide a way to execute a function via HTTP. You must execute it from your Laravel app through the provided methods.**


Finally, Sidecar doesn't replace Vapor in any way. In fact, PHP is not even one of the default AWS supported runtimes!
Finally, Sidecar doesn't replace Vapor in any way. In fact, PHP is not even one of the default AWS supported runtimes!
3 changes: 2 additions & 1 deletion src/Deployment.php
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
namespace Hammerstone\Sidecar;

use Exception;
use Illuminate\Support\Str;
use Hammerstone\Sidecar\Clients\LambdaClient;
use Hammerstone\Sidecar\Events\AfterFunctionsActivated;
use Hammerstone\Sidecar\Events\AfterFunctionsDeployed;
Expand Down Expand Up @@ -209,7 +210,7 @@ protected function warmLatestVersion(LambdaFunction $function)
$results = Sidecar::warmSingle($function, $async = false, $version);

if ($warmed = count($results)) {
Sidecar::log("Warmed $warmed instances.");
Sidecar::log("Warmed $warmed " . Str::plural("instance", $warmed));
} else {
Sidecar::log('No instances warmed. If this is unexpected, confirm your `warmingConfig` method is set up correctly.');
}
Expand Down
12 changes: 1 addition & 11 deletions src/Runtime.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,22 +10,14 @@ abstract class Runtime

public const NODEJS_12 = 'nodejs12.x';

public const NODEJS_10 = 'nodejs10.x';

public const PYTHON_39 = 'python3.9';

public const PYTHON_38 = 'python3.8';

public const PYTHON_37 = 'python3.7';

public const PYTHON_36 = 'python3.6';

public const PYTHON_27 = 'python2.7';

public const RUBY_27 = 'ruby2.7';

public const RUBY_25 = 'ruby2.5';


public const JAVA_11 = 'java11';

public const JAVA_8_LINUX2 = 'java8.al2';
Expand All @@ -38,7 +30,5 @@ abstract class Runtime

public const DOT_NET_31 = 'dotnetcore3.1';

public const DOT_NET_21 = 'dotnetcore2.1';

public const PROVIDED_AL2 = 'provided.al2';
}