crypto: make DH error messages consistent

Refs: nodejs/node#31178 Refs: nodejs/node#31445
abhishekumar-tyagi · Feb 19, 2020 · 505f3e8 · 505f3e8
1 parent b8e4177
commit 505f3e8
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/node_crypto.cc b/src/node_crypto.cc
@@ -5690,7 +5690,7 @@ void DiffieHellman::DiffieHellmanGroup(
  const node::Utf8Value group_name(env->isolate(), args[0]);
  const modp_group* group = FindDiffieHellmanGroup(*group_name);
  if (group == nullptr)
- return THROW_ERR_CRYPTO_UNKNOWN_DH_GROUP(env, "Unknown group");
+ return THROW_ERR_CRYPTO_UNKNOWN_DH_GROUP(env);
 
  initialized = diffieHellman->Init(group->prime,
  group->prime_size,

diff --git a/test/parallel/test-crypto-dh.js b/test/parallel/test-crypto-dh.js
@@ -392,7 +392,7 @@ assert.throws(
  {
  name: 'Error',
  code: 'ERR_CRYPTO_UNKNOWN_DH_GROUP',
- message: 'Unknown group'
+ message: 'Unknown DH group'
  },
  'crypto.getDiffieHellman(\'unknown-group\') ' +
  'failed to throw the expected error.'