Skip to content
This repository has been archived by the owner on Feb 12, 2021. It is now read-only.

Avoid using args and kwargs and remove extra comments. #34

Open
singh1114 opened this issue Jun 30, 2017 · 11 comments
Open

Avoid using args and kwargs and remove extra comments. #34

singh1114 opened this issue Jun 30, 2017 · 11 comments

Comments

@singh1114
Copy link
Collaborator

Avoid the use of kwargs and args whenever possible.

singh1114 added a commit to singh1114/scancode-server that referenced this issue Jun 30, 2017
singh1114 added a commit to singh1114/scancode-server that referenced this issue Jul 2, 2017
RajuKoushik pushed a commit that referenced this issue Jul 2, 2017
@chetanya-shrimali
Copy link

I would like to work on the issue addressed. Also the code must follow the pip8 style guide. I can work on the same.

@chetanya-shrimali
Copy link

@pombredanne @singh1114 reviews!!

@pombredanne
Copy link
Contributor

@chetanya-shrimali you would need to sync up with @singh1114 on this. This is in his branch

@singh1114
Copy link
Collaborator Author

singh1114 commented Oct 4, 2017

@chetanya-shrimali I think we have taken care of this. Still, if you want to work on this, please explain how are you going to take care of the issue and we will go forward with this.

@chetanya-shrimali
Copy link

@singh1114 Actually, when I checked the code on pip8 online checker it gave like a variety of errors regarding the format of code. So basically I will reformat the code depending on the number of characters per line, remove extra white spaces, order the comments etc. That's the one thing I would like to do.
Other is regarding the update of the readme file. I will open an issue regarding that if it is suitable according to you.

@singh1114
Copy link
Collaborator Author

singh1114 commented Oct 4, 2017

@chetanya-shrimali Working in separate issue would be great but we have not encountered issues like whitespaces and all. Please share the results that you have encountered before working on the issues. This will better for you. Otherwise, you will be doing extra efforts.

@chetanya-shrimali
Copy link

I am attaching some screenshots please have a look at it. @singh1114
screenshot from 2017-10-04 22-32-54
screenshot from 2017-10-04 22-32-29
screenshot from 2017-10-04 22-32-19
screenshot from 2017-10-04 22-32-06
screenshot from 2017-10-04 22-31-53
screenshot from 2017-10-04 22-31-09

@singh1114
Copy link
Collaborator Author

singh1114 commented Oct 5, 2017

@chetanya-shrimali We have a limit of 100 characters per line. You can check the .travis.yml file. Still, if you can bring all those to that limit than it would be great. I have to check my code for those issues. travis used to check all those things for us. It never showed us those errors. We need to reconfirm that.

https://travis-ci.org/nexB/scancode-server

@chetanya-shrimali
Copy link

@singh1114 yes, I can totally do that. I will send the PR soon.

@singh1114
Copy link
Collaborator Author

@chetanya-shrimali Open a new issue for this. We are going to close this one. In that issue explain everything that you are going to do.

@chetanya-shrimali
Copy link

@singh1114 Thats perfect. I'll open a new one.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants