Improve XLSX creation #206 #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now check that the content is correctly added before calling XlsxWriter and report and error if the truncated can be truncated. Several other adaptations of a cell content are done: - Create a combined license expression for expressions. - Keep only unique values in lists, preserving ordering. - Collect the main attribute of well known scan fields - Convert mappings to YAML. - Truncate the "description" field to the first five lines. - Convert anything unknown to string. - Normalize line endings - Truncate to a maximum_length any field too long to fit in an XLSX cell and report error. Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Thomas Druez <[email protected]>
Signed-off-by: Thomas Druez <[email protected]>
Signed-off-by: Thomas Druez <[email protected]>
Signed-off-by: Thomas Druez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XlsxWriter
We now check that the content is correctly added before calling
XlsxWriter and report and error if the truncated can be truncated.
Several other adaptations of a cell content are done:
cell and report error.
Signed-off-by: Philippe Ombredanne [email protected]