Feature/retryability #14
Conversation
There was a problem hiding this comment.
Sorry this is late. Can we set a default timeout for these functions and make options optional param to these functions?
Also, I think we need to add this functionality to all shadow* functions. I updated my repo to this new package version and the shadowFind and shadowGet functions are fixed but my tests are failing on shadowContains.
| @@ -8,13 +10,17 @@ declare namespace Cypress { | |||
| composed?: Boolean; | |||
| }; | |||
|
|
|||
| type CommandOptions = { | |||
There was a problem hiding this comment.
It appears CommandOptions is already declared as an interface in Cypress library.
As such a typescript error is issued because you can't redeclare a type. Can we change this type name to ShadowOptions or something similar? If we extend CommandOptions by declaring this an interface, it results in prevSubject being required.
There was a problem hiding this comment.
I know this was awhile ago, but I'm having this exact problem. I'm using Typescript with Cypress and I am unable to specify a timeout on shadowGet() or shadowFind() because { timeout: 5000 } is not assignable to parameter of type Cypress.CommandOptions. Any chance this is something we could fix? I can open a new issue if necessary.
There was a problem hiding this comment.
I see these typings were not updated properly:
https:/abramenal/cypress-shadow-dom/blob/master/index.d.ts#L25
Are you able to create a MR with that fix?
There was a problem hiding this comment.
Is it as simple as changing the shadowFind, shadowFirst, shadowGet and shadowLast methods to use ShadowCommandOptions? Also looks like you have a typo in ShadowEventOptios - I could fix that too.
Closes #9