Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync #5290

Merged
merged 34 commits into from
Sep 18, 2024
Merged

sync #5290

merged 34 commits into from
Sep 18, 2024

Conversation

Neilpang
Copy link
Member

sync

scruel and others added 30 commits February 27, 2024 12:40
… backup certificates before overwrite, and force unifi to start with unifi-core if both are installed.
…e string 'id' dns_dynv6.sh

This will now search for `"id:"` instead of `id` and therefore will only find the id field and not any other field containing the sub-string 'id'
… upper case characters would not be accepted (dynv6 API rejects those).

Now the fulldomain will be cast to lowercase first which should not make
any difference since DNS is case insensitive.
…mply with requested standards.

This does not change any functionality in this special case but the
request for [:upper:] and [:lower:] makes a lot of sense in general.
Bark API v2 is now fully implemented. BARK_SOUND is now also optional, as intended by the API.
Add permissions to:
- Client functions
- DNS zone functions
…tool after Ubiquiti removed it, update system configuration for stronger ciphers, and back up existing certificates prior to change.
Ubiquiti removed keytool (and java) from recent releases of Unifi OS. This moves from keytool to openssl's native pkcs12.

Tested on Unifi Dream Machine which runs Unifi OS and a built-in Unifi controller.

Also added backup of existing files prior to change in case anything goes wrong, and update system configuration with compatible ciphers.
2 Bugfixes of `dns_dynv6.sh`: 1. domains containing 'id' are now working as intended and 2. hostnames are now cast to lowercase on the fly
Updating unifi deploy hook - remove keytool requirement
Fix missing XML Escape in Password of INWX DNS API
Prevent leaving blank lines in config file after cleared keys.
fraenki and others added 4 commits September 16, 2024 16:49
With nsupdate the rule seems to be: filenames need to be wrapped
in double quotes, while all other options must not use double quotes.
Hence there is no way to resolve the shellcheck offense, because
the key requires quotes, but the other options must not use quotes.
URGENT: fix dns_nsupdate when NSUPDATE_OPT is empty
Copy link

Welcome
First thing: don't send PR to the master branch, please send to the dev branch instead.
Please make sure you've read our DNS API Dev Guide and DNS-API-Test.
Then reply on this message, otherwise, your code will not be reviewed or merged.
We look forward to reviewing your Pull request shortly ✨
注意: 必须通过了 DNS-API-Test 才会被 review. 无论是修改, 还是新加的 dns api, 都必须确保通过这个测试.

@Neilpang Neilpang merged commit fc7f861 into master Sep 18, 2024
34 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants