Automatic monkey patching, workaround for Odoo 10 issue, and tests! #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an attempt to fix acsone/setuptools-odoo#10 By installing a .pth file named zzz_odoo_autodiscover.pth that will run last, but before the main program starts, we can remove the dummy odoo package that is created by the *nspkg.pth files from setuptools. That leaves a chance to odoo/__init__.py to run when the main program imports odoo. The declare_namespace in odoo/addons/__init__.py will then repopulate odoo.addons.__path__. Yes, that is tricky... it's the price to live on the border line where. To be spec compliant, odoo/__init__.py should be empty. A better solution is to be found for v11.
otherwise we are in a situation with a child ns package without parent, which can confuse python
remove dependency on odoo so odoo-autodiscover can be installed before odoo
including test for it
This was referenced Sep 15, 2017
Because with tox and ubuntu 16, pip does not get installed in the venv...
Don't attempt to use namespace packages anymore for odoo.addons. It's definitely impossible as long as there is code in odoo/__init__.py We simply explore sys.path to find odoo/addons directories and add that to Odoo's ad_paths.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pip install -esetuptools-odoo#18*-autodiscoverscripts