Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise warning when action input does not match action.yml. #429

Merged
merged 1 commit into from
Apr 21, 2020
Merged

Raise warning when action input does not match action.yml. #429

merged 1 commit into from
Apr 21, 2020

Conversation

TingluoHuang
Copy link
Member

Fix: #428

ericsciple
ericsciple reviewed Apr 21, 2020
View reviewed changes
src/Runner.Worker/ActionRunner.cs Outdated
{
if (!validInputs.Contains(input))
{
ExecutionContext.Warning($"Unrecognized input '{input}', valid inputs are ['{string.Join("', '", validInputs)}']");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: consider, "Unexpected input ..."

Copy link
Collaborator

@ericsciple ericsciple Apr 21, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder how hard it would be to plumb the line/column/file info through.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we drive this change into manifestManager.ValidateInputs or something? And it could output a list of warnings?

@TingluoHuang TingluoHuang force-pushed the users/tihuang/warninvalidinput branch from 392e344 to 5f619b3 Compare April 21, 2020 21:07
@TingluoHuang TingluoHuang force-pushed the users/tihuang/warninvalidinput branch from 5f619b3 to 105d37b Compare April 21, 2020 23:29
@TingluoHuang TingluoHuang merged commit d5c54f9 into master Apr 21, 2020
@TingluoHuang TingluoHuang deleted the users/tihuang/warninvalidinput branch April 29, 2020 14:58
@allenevans allenevans mentioned this pull request Jun 1, 2020
Open
@TingluoHuang TingluoHuang mentioned this pull request Jun 6, 2020
Closed
@allenevans allenevans mentioned this pull request Nov 29, 2020
Open
@danielhelfand danielhelfand mentioned this pull request Jan 22, 2021
Closed
AdamOlech pushed a commit to antmicro/runner that referenced this pull request Jan 28, 2021
@TingluoHuang
Raise warning when action input does not match action.yml. (actions#429)
a5fdc07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericsciple ericsciple ericsciple approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

verify configuration directive names
2 participants
@TingluoHuang @ericsciple