Skip to content

Commit

Permalink
Merge pull request #627 from actions/robherley/v4.4.2
Browse files Browse the repository at this point in the history
Bump `@actions/artifact` to 2.1.11
  • Loading branch information
robherley authored Oct 8, 2024
2 parents 604373d + b1d4642 commit 8448086
Show file tree
Hide file tree
Showing 6 changed files with 84,065 additions and 94,108 deletions.
22 changes: 17 additions & 5 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,8 @@ jobs:
echo "Lorem ipsum dolor sit amet" > path/to/dir-1/file1.txt
echo "Hello world from file #2" > path/to/dir-2/file2.txt
echo "Hello from a symlinked file" > symlink/original.txt
ln -s $(pwd)/symlink/original.txt symlink/file.txt
ln -s $(pwd)/symlink/original.txt symlink/abs.txt
ln -s original.txt symlink/rel.txt
shell: bash

# Upload a single file artifact
Expand Down Expand Up @@ -87,7 +88,9 @@ jobs:
uses: ./
with:
name: 'Symlinked-Artifact-${{ matrix.runs-on }}'
path: symlink/file.txt
path: |
symlink/abs.txt
symlink/rel.txt
# Download Artifact #1 and verify the correctness of the content
- name: 'Download artifact #1'
Expand Down Expand Up @@ -159,12 +162,21 @@ jobs:

- name: 'Verify symlinked artifact'
run: |
$file = "from/symlink/file.txt"
if(!(Test-Path -path $file))
$abs = "from/symlink/abs.txt"
if(!(Test-Path -path $abs))
{
Write-Error "Expected file does not exist"
}
if(!((Get-Content $abs) -ceq "Hello from a symlinked file"))
{
Write-Error "File contents of downloaded artifact are incorrect"
}
$rel = "from/symlink/rel.txt"
if(!(Test-Path -path $rel))
{
Write-Error "Expected file does not exist"
}
if(!((Get-Content $file) -ceq "Hello from a symlinked file"))
if(!((Get-Content $rel) -ceq "Hello from a symlinked file"))
{
Write-Error "File contents of downloaded artifact are incorrect"
}
Expand Down
2 changes: 1 addition & 1 deletion .licenses/npm/@actions/artifact.dep.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

1 comment on commit 8448086

@timjensen-kr
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robherley this PR is causing the upload-artifact job to fail for our org and pinning to the previous version fixes it. Is this getting reported elsewhere? We have releases this is blocking and are trying to figure out how to move forwards without pinning to an older version of the action

Please sign in to comment.