Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CecabankRest: Add AP/GP #5295

Merged
merged 2 commits into from
Oct 16, 2024
Merged

CecabankRest: Add AP/GP #5295

merged 2 commits into from
Oct 16, 2024

Conversation

gasb150
Copy link
Collaborator

@gasb150 gasb150 commented Oct 8, 2024

Summary

This commit implement Apple Pay and Google Pay payment methods the unit and remote tests, and fix few faling tests in current implementation.

SER-1431

Unit Tests:

Finished in 0.031554 seconds.
20 tests, 106 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed

Remote Tests:

Finished in 20.386373 seconds.
20 tests, 69 assertions, 1 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 95% passed

Rubocop

801 files inspected, no offenses detected

Copy link
Collaborator

@javierpedrozaing javierpedrozaing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Job, LGTM

Copy link
Contributor

@naashton naashton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @gasb150 - would you mind adding a Changelog?

Summary
----------------
This commit implement Apple Pay and Google Pay payment methods
the unit and remote tests, and fix few faling tests in current
implementation.

[SER-1431](https://spreedly.atlassian.net/browse/SER-1431)

Unit Tests:
----------------
Finished in 0.031554 seconds.
20 tests, 106 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Remote Tests:
----------------
Finished in 20.386373 seconds.
20 tests, 69 assertions, 1 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
95% passed

Rubocop
----------------
801 files inspected, no offenses detected
@naashton naashton merged commit 32b58d6 into master Oct 16, 2024
5 checks passed
@naashton naashton deleted the SER-1431-Cecabank_AP_GP branch October 16, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants