-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make actix-rt (and actix itself) work with tokio console #445
Comments
Duplicate of actix/actix-web#2646. Fine to keep it open though since the change will need to happen here. |
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When using tokio-console, all tasks run in actix-rt appear meaningless because they look like they are being run from the same line (see image below for illustrations). This issue used to be a tokio issue, but this was just fixed in this pr (tokio-rs/tokio#4483).
Now, have looked into where actix-rt could add "track_caller" attributes to different functions to have the same effect as tokio, but I don't know if this will work due to how actix-rt spawns futures by sending them across channels to arbiters.
At least actix-rt could add
track_caller
to a few key functions and this would greatly improve usability.actix-net/actix-rt/src/system.rs
Line 208 in d229c1e
actix-net/actix-rt/src/system.rs
Line 235 in d229c1e
actix-net/actix-rt/src/runtime.rs
Line 56 in d229c1e
actix-net/actix-rt/src/runtime.rs
Line 76 in d229c1e
actix-net/actix-rt/src/lib.rs
Line 202 in d229c1e
The text was updated successfully, but these errors were encountered: