Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log-out #6

Closed
1 task done
tiffany-tang opened this issue Oct 5, 2018 · 10 comments
Closed
1 task done

Log-out #6

tiffany-tang opened this issue Oct 5, 2018 · 10 comments
Assignees
Labels
bug Something isn't working priority-3

Comments

@tiffany-tang
Copy link
Collaborator

tiffany-tang commented Oct 5, 2018

When I am using this web-app on another device or someone else is using my device,
I want to log out of my account
So no one else can access my account.

Acceptance Criteria

  • To have a 'log out' button

relates to: #5

@iteles
Copy link
Collaborator

iteles commented Oct 9, 2018

@Cleop The positioning of this button is TBDiscussed when we get to it 😊

@tiffany-tang This is a feature that I have always felt was very necessary to protect the children's privacy but I'm very curious to see if it even comes up in the user testing on 22-Oct!

@tiffany-tang
Copy link
Collaborator Author

@iteles I put it as priority-3 for the time being as I have some questions regarding GDPR I have yet to ask. It is definitely an important feature for the app.

@tiffany-tang
Copy link
Collaborator Author

@RobStallion Looks fine to me so far

@RobStallion
Copy link
Collaborator

@tiffany-tang Great 👍 . If you're happy with this issue then go ahead and close the issue.

@tiffany-tang tiffany-tang added bug Something isn't working and removed please-test labels Oct 25, 2018
@tiffany-tang
Copy link
Collaborator Author

Just tested this again and when I logged out it says "Forbidden".

@tiffany-tang tiffany-tang reopened this Oct 25, 2018
@RobStallion
Copy link
Collaborator

Hey @tiffany-tang. I have not been able to recreate this issue. If you can recreate the issue would you be able to list the steps that you took to get this to happen and open a new issue?

For example, the user you logged in as, if you had logged any emotions that day, etc. Thanks

@tiffany-tang
Copy link
Collaborator Author

@RobStallion
I have retried this on a Motorola phone and Samsung phone with Google Chrome, and on an Iphone8 with Safari for the accounts test1, 2, 3, 4, 5, 6, 7, 8, and test_user. I couldn't re-create this as well. Closing this.

@SimonLab
Copy link
Collaborator

SimonLab commented Oct 26, 2018

@RobStallion I manage to recreate the "forbidden" issue. This is caused when the cookien containing the user session is not valid anymore (you can try to delete it and click on logout)
image

@SimonLab SimonLab reopened this Oct 26, 2018
@Cleop
Copy link
Collaborator

Cleop commented Oct 29, 2018

@SimonLab - where possible would you be able to open a new issue for bugs that occur once the initial issue has been tested and closed?

@SimonLab
Copy link
Collaborator

After a bit more research the "forbidden" error message is the normal logic. It happens when the session is not valid anymore and protect from other people trying to logout users.
Maybe a recent deployment invalidate the current session and it's why the error message appears but I don't think this should occurs once the application is on production

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority-3
Projects
None yet
Development

No branches or pull requests

5 participants