Emotion log flow #28
Merged
Emotion log flow #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Danwhy
reviewed
Oct 16, 2018
mix.exs
Outdated
| {:cowboy, "~> 1.0"}, | ||
| {:excoveralls, "~> 0.10", only: :test}, | ||
| {:credo, "~> 0.10.0", only: [:dev, :test], runtime: false}, | ||
| {:autoform, github: "dwyl/autoform"} |
There was a problem hiding this comment.
I'd change this to:
{:autoform, git: "https:/dwyl/autoform.git", tag: "0.1"}Otherwise any updates to the master branch would potentially break you
There was a problem hiding this comment.
Oh I didn't know that. Good spot. Thanks for the info 👍
| add :classwork, :boolean, default: false, null: false | ||
| add :homework, :boolean, default: false, null: false | ||
| add :else, :boolean, default: false, null: false | ||
| add :reason, :string |
There was a problem hiding this comment.
Is this what you decided on for the table in the end, or is this subject to change?
There was a problem hiding this comment.
It is what we decided but can be changed if there is a better suggestion. See #22 for more info.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
credofor code consistency andexcoverallsfor code cov #24Creates
trusted_adult,user,happyandangrydb tables #22 #13Creates landing page #15 #7
Creates beginnings of emotion logging flow #7