Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 32-bit UUID support. #62

Merged
merged 2 commits into from
Apr 24, 2023
Merged

Added 32-bit UUID support. #62

merged 2 commits into from
Apr 24, 2023

Conversation

anthonytw
Copy link
Contributor

Previously the library only supported 16-bit standard UUID, but the spec allows for 32-bit UUIDs as well. Encountering a 32-bit UUID caused the code to raise an exception. This fix adds support for 32-bit standard UUIDs.

Resolves #61

Previously the library only supported 16-bit standard UUID, but the spec
allows for 32-bit UUIDs as well. Encountering a 32-bit UUID caused the
code to raise an exception. This fix adds support for 32-bit standard
UUIDs.
@dhalbert dhalbert self-requested a review April 21, 2023 13:52
@dhalbert
Copy link
Contributor

Hi, check the build log for pylint complaints: https:/adafruit/Adafruit_Blinka_bleio/actions/runs/4761020028/jobs/8461884121?pr=62

You can use pre-commit to run these checks locally: https://learn.adafruit.com/creating-and-sharing-a-circuitpython-library/check-your-code

@anthonytw
Copy link
Contributor Author

I'll look at the complaints, thanks for mentioning the pre-commit option, I've not used that before. I'll recommit in a bit.

@anthonytw
Copy link
Contributor Author

Okay, looks like that worked. Sorry the change is a bit larger now, I had to restructure things a bit to get it to stop complaining about "too many branches".

Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for future-proofing this. I'm surprised any 32-bit UUID's are out in the wild, but we may as well handle them. I hope people will not try to use them with the HCI code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for 32-bit UUIDs
2 participants