Wippersnapper preprocessor script for printing the library versions to boot outtxt #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentru
requested changes
Oct 11, 2024
| # check argument not null and folder path exists | ||
| PRINT_DEPENDENCIES_AS_HEADER_FILENAME = sys.argv[sys.argv.index("--include_print_dependencies_header") + 1] if len(sys.argv) > sys.argv.index("--include_print_dependencies_header") + 1 else None | ||
| if PRINT_DEPENDENCIES_AS_HEADER_FILENAME is None or not os.path.exists(PRINT_DEPENDENCIES_AS_HEADER_FILENAME): | ||
| raise AttributeError("Header file path not found or not provided to --include_print_dependencies_header argument") |
| PRINT_DEPENDENCIES_AS_HEADER_FILENAME = None | ||
| if "--include_print_dependencies_header" in sys.argv: | ||
| # check argument not null and folder path exists | ||
| PRINT_DEPENDENCIES_AS_HEADER_FILENAME = sys.argv[sys.argv.index("--include_print_dependencies_header") + 1] if len(sys.argv) > sys.argv.index("--include_print_dependencies_header") + 1 else None |
There was a problem hiding this comment.
You're re-calculating sys.argv.index, it happens here and on L42. Instead, try storing the sys.argv.index into an index variable at the top of this conditional
| @@ -104,7 +114,7 @@ def manually_install_esp32_bsp(repo_info): | |||
| # Assemble git url | |||
| repo_url = "git clone -b {0} https:/{1}/arduino-esp32.git esp32".format(repo_info.split("/")[1], repo_info.split("/")[0]) | |||
| # Locally clone repo (https://docs.espressif.com/projects/arduino-esp32/en/latest/installing.html#linux) | |||
| os.system("mkdir -p /home/runner/Arduino/hardware/espressif") | |||
| subprocess.run("mkdir -p /home/runner/Arduino/hardware/espressif", shell=True, check=True) | |||
There was a problem hiding this comment.
Why is this being changed from os.system?
There was a problem hiding this comment.
Also, check the subprocess.run result (result = subproces.run(..)) after this operation on L117. You do this a in the calls below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@brentru this is tied in with adafruit/Adafruit_Wippersnapper_Arduino#607
It adds a new flag to allow specifying the location of the header file to be generated/replaced
--include_print_dependencies_headeralthough now I've settled on not being able to modify the build flags I could probably pick a better name as it no longer adds an extra include to the build flags.