Add some compatibility imports #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UnknownPlatypus
force-pushed
the
add_some_compatibility_imports
branch
from
85fc8a1
to
2fd8266
Compare
UnknownPlatypus
force-pushed
the
add_some_compatibility_imports
branch
from
2fd8266
to
dbeecc8
Compare
|
I'm not quite fan of having so much compatibility import documentation section. Maybe it's better to group everything in a section at the end ? |
adamchainz
approved these changes
Sep 24, 2023
There was a problem hiding this comment.
I also noticed some compatibility imports were not mentioned in the readme so I've added the missing sections.
💪
I'm not quite fan of having so much compatibility import documentation section. Maybe it's better to group everything in a section at the end ?
I would prefer to keep the docs per-version based, so you can read version X release notes alongside its django-upgrade docs section and compare what will be auto-upgraded.
adamchainz
force-pushed
the
add_some_compatibility_imports
branch
from
dbeecc8
to
a959224
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I've added a compatibility import replacement for django 4.0 (
TRANSLATOR_COMMENT_MARK, we were actually importing this in our code base at my work) and while at it, added some older one fitting existing target-version settings.Fixes #293
I also noticed some compatibility imports were not mentioned in the readme so I've added the missing sections.
Cheers