-
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MinVerBuildMetadata not used in nupkg version #146
Comments
@blairconrad build metadata |
Reason being: build metadata really is just metadata. It's not part of the version. If it was included in the filename, you wouldn't be able to use the filesystem as a package source, since you'd have duplicate packages. |
Thanks for the explanation. Ironically, this lack of metadata in the filename is exactly what's keeping me from using the filesystem as a package source. I want to subscribe to 2 different nupkgs, each of which were built as one-commit-past- As a side note, I'd've expected diagnostic-level output to output its calculated |
GitVersion had been putting part of the branch name in the generated filenames, and I realized that we'd lose that when switching to MinVer, but I had (erroneously) thought that the metadata would allow me to work around that. |
Can you describe more about this use case? I assume they were built on different branches?
👍 sounds reasonable. Raised #147. |
Sure. It's niche. I used to be able to |
OK. FWIW, I think I'm going to release another beta which will expose the pre-release part of the version as something like <Target Name="MyTarget" AfterTargets="MinVer" Condition="'$(BRANCH)' != ''">
<PropertyGroup>
<PackageVersion>$(MinVerMajor).$(MinVerMinor).$(MinVerPatch)-$(MinVerPrerelease).$(BRANCH)+$(MinVerBuildMetadata)</PackageVersion>
<Version>$(PackageVersion)</Version>
</PropertyGroup>
</Target> I may even consider adding some kind of new input variable which allows you to inject a pre-release prefix and/or suffix into MinVer itself. 💭 |
@blairconrad I guess this question is answered, but keep an eye on the new beta for things that might help your use case. |
Indeed. Thanks for your time! |
Hi. I specified the
MinVerBuildMetadata
environment variable so I could include build metadata in the version and expected to see it appear in the nupkg version, but it does not:Produced
FakeItEasy.5.0.0-alpha.0.160.nupkg
.Do I misunderstand?
The text was updated successfully, but these errors were encountered: