Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide version from console when MSBuild log level is quiet/minimal/normal #170

Closed
adamralph opened this issue Dec 13, 2018 · 3 comments
Closed

Hide version from console when MSBuild log level is quiet/minimal/normal #170

adamralph opened this issue Dec 13, 2018 · 3 comments
Labels
enhancement New feature or request
Milestone
1.0.0

Comments

@adamralph
Copy link
Owner

adamralph commented Dec 13, 2018 •
edited
Loading

Currently, when building a project with MinVer installed, the version appears in output like so:

image

This is a side effect of using the MSBuild Exec task to invoke an executable to do the versioning work.

If we manage to pull off #112, this will go away, but in the meantime, we can restrict this to showing only if the MSBuild log level is detailed or diagnostic by specifying StandardOutputImportance="Low".
@adamralph adamralph added enhancement New feature or request on-hold This can't be done yet labels Dec 13, 2018
@adamralph

This comment has been minimized.

Sign in to view
@adamralph adamralph changed the title Hide version from console Hide version from console when MSBuild log level is normal or higher Dec 18, 2018
@adamralph adamralph changed the title Hide version from console when MSBuild log level is normal or higher Hide version from console when MSBuild log level is quiet/minimal/normal Dec 18, 2018
@adamralph adamralph mentioned this issue Dec 18, 2018
Merged
@adamralph
Copy link
Owner Author

ZOMG by spelunking the MSBuild source code, I found a solution to hide the version from stdout unless the MSBuild log level is detailed or diagnostic: #175

/cc @blairconrad

@adamralph adamralph added this to the 1.0.0 milestone Dec 18, 2018
@adamralph adamralph removed the on-hold This can't be done yet label Dec 18, 2018
@adamralph adamralph self-assigned this Dec 18, 2018
@adamralph
Copy link
Owner Author

Released in beta 2.

@adamralph adamralph removed their assignment Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
1 participant
@adamralph