Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MinVerPreRelease terminates before the first hyphen in the pre-release identifiers #479

Closed
adamralph opened this issue Jan 18, 2021 · 1 comment · Fixed by #478 or #490
Closed
Labels
bug Something isn't working
Milestone

Comments

@adamralph
Copy link
Owner

Version(s)

1.0.0 - 2.4.0

To reproduce

Steps to reproduce the behaviour:

  1. Take a .NET project with MinVer installed in a Git repo
  2. Create a tag named 1.2.3-foo-bar
  3. Set MINVERVERBOSITY to "detailed"
  4. Build the project

Expected behaviour

Standard error contains MinVer: [output] MinVerPreRelease=foo-bar.

Actual behaviour

Standard error contains MinVer: [output] MinVerPreRelease=foo.

Workarounds

Extract the pre-release identifiers from PackageVersion or Version.

Additional context

Thanks to @kojoru for identifying and fixing this bug in #478.

@adamralph adamralph added the bug Something isn't working label Jan 18, 2021
@adamralph adamralph added this to the 2.5.0 milestone Jan 18, 2021
@adamralph adamralph linked a pull request Jan 18, 2021 that will close this issue
@adamralph
Copy link
Owner Author

This has been fixed and manually verified in #478. Before closing this issue, a test should be added after the current tests have been moved to a test project.

This was referenced Mar 15, 2021
This was referenced Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant