Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear ItemGroups before using them #218

Merged
merged 1 commit into from
Apr 5, 2019
Merged

Clear ItemGroups before using them #218

merged 1 commit into from
Apr 5, 2019

Conversation

bording
Copy link
Collaborator

@bording bording commented Apr 5, 2019

Fixes #217

I was originally going to put the Remove next to the first Include for each group, but that doesn't work for MinVerConsoleOutput, so I decided to add a dedicated group just for the Removes instead.

@adamralph
Copy link
Owner

👌 thanks!

@adamralph adamralph merged commit 15af8aa into adamralph:master Apr 5, 2019
@bording bording deleted the clear-item-groups branch April 5, 2019 13:40
@adamralph adamralph added this to the 1.1.0 milestone Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

MinVer can fail if internal item groups are already populated
2 participants
@bording @adamralph