Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify inputs #82

Merged
merged 1 commit into from
Nov 4, 2018
Merged

simplify inputs #82

merged 1 commit into from
Nov 4, 2018

Conversation

adamralph
Copy link
Owner

Relates to #3.

@adamralph adamralph added this to the 1.0.0 milestone Nov 4, 2018
@adamralph
Copy link
Owner Author

@bording after more thought, and after feedback in FakeItEasy/FakeItEasy#1484, I decided to simplify the inputs a little, so that the user is guided more towards what should be in an environment variable and what should be in an MSBuild property.

I also decided to rename MinVerMinimumMajorMinor to MinVerMajorMinor since the former is a little unwieldy, and it suggests that something else (i.e. a tag) should be moving the version further forward, with this property purely indicating a minimum. Under normal usage, it is the current major minor range, even if a later tag will override it. I.e. when moving to a new range, the correct thing to do is to change that value rather than push a later tag. If you are going to push a later tag, it implies that you're not really using that value anyway, and you should remove it and just use tags throughout.

Interested to know your thoughts.

BTW - I've decided to do at least another round of alpha, but perhaps just on my own projects. There's been enough change since alpha 12 that I'm not confident of advertising a beta straight away.

@adamralph adamralph merged commit b3d7e2f into master Nov 4, 2018
@adamralph adamralph deleted the simplify-inputs branch November 4, 2018 14:41
@adamralph
Copy link
Owner Author

Released in alpha 13.

@bording
Copy link
Collaborator

bording commented Nov 5, 2018

This all makes sense to me. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants