Refactor targets #89
Merged
Refactor targets #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamralph
commented
Nov 5, 2018
| <MinVerOptions Include="--tag-prefix "$(MinVerTagPrefix)"" /> | ||
| <MinVerOptions Include="--verbose" Condition="'$(MinVerVerbose)' == 'true'" /> | ||
| </ItemGroup> | ||
| <Exec Command="dotnet "$(MSBuildThisFileDirectory)../MinVer/MinVer.Cli.dll" @(MinVerOptions->'%(Identity)', ' ')" ConsoleToMSBuild="true"> |
There was a problem hiding this comment.
@bording do you have an opinion on this change? It's more lines, but it gets rid of MinVerVerboseOption and the 212 character options expression, which also had to have a placeholder for MinVerVerboseOption, and that had to include it's leading space separator, which always felt a bit ugly.
There was a problem hiding this comment.
I like it! Much cleaner, and it would be easier to add new options in the future that way.
|
Released in alpha 14. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #3.