Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

overhaul options #96

Merged
merged 1 commit into from
Nov 14, 2018
Merged

overhaul options #96

merged 1 commit into from
Nov 14, 2018

Conversation

adamralph
Copy link
Owner

relates to #3

@adamralph adamralph added this to the 1.0.0 milestone Nov 14, 2018
@adamralph adamralph merged commit 15d7eea into master Nov 14, 2018
@adamralph adamralph deleted the options branch November 14, 2018 17:12
@bording
Copy link
Collaborator

bording commented Nov 14, 2018

🤔 I'll need to take a close look at this later, but initial reaction is that this feels like too much and there's likely a simpler way.

@adamralph
Copy link
Owner Author

Thanks @bording, as usual your opinion would be valued.

@adamralph adamralph mentioned this pull request Nov 14, 2018
Merged
@adamralph
Copy link
Owner Author

BTW the precedence was the wrong way round. I've fixed it in #98.

@bording bording mentioned this pull request Nov 15, 2018
Merged
@adamralph
Copy link
Owner Author

Superseded by #102.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@adamralph @bording