Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CreateWorkload #2251

Merged
merged 23 commits into from
Sep 7, 2023
Merged

Add CreateWorkload #2251

merged 23 commits into from
Sep 7, 2023

Conversation

panh99
Copy link
Contributor

@panh99 panh99 commented Aug 24, 2023 •
edited
Loading

Add CreateWorkload Driver API that requests and returns a workload_id

Update in_memory_state.py and sqlite3_state.py

Add validation processes to check the validity of workload_id

danieljanes
danieljanes requested changes Aug 25, 2023
View reviewed changes
Copy link
Member

@danieljanes danieljanes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR is in great shape, I only added two minor comments.

examples/mt-pytorch/driver.py Outdated Show resolved Hide resolved
src/py/flwr/server/state/in_memory_state.py Outdated Show resolved Hide resolved
src/py/flwr/server/state/state_test.py Outdated Show resolved Hide resolved
@panh99 panh99 requested review from danieljanes and tanertopal and removed request for jafermarq September 5, 2023 16:42
@panh99 panh99 mentioned this pull request Sep 6, 2023
Merged
@danieljanes danieljanes enabled auto-merge (squash) September 7, 2023 13:04
@danieljanes danieljanes merged commit 9e645a1 into main Sep 7, 2023
26 checks passed
@danieljanes danieljanes deleted the wl-id branch September 7, 2023 13:11
tanertopal added a commit that referenced this pull request Sep 7, 2023
@tanertopal
Merge branch 'main' of github.com:adap/flower into changelog_detection
f6ee5c8 
* 'main' of github.com:adap/flower:
  Increase minimum Python version to 3.8 (#2306)
  Fix mypy error in `flwr/server/strategy/aggregate.py` (#2312)
  Add CreateWorkload (#2251)
  Fix quantization type error (#2311)
  Re-add the tutorials to the docs navbar (#2310)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieljanes danieljanes danieljanes approved these changes

@tanertopal tanertopal Awaiting requested review from tanertopal tanertopal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@panh99 @tanertopal @danieljanes @charlesbvll