-
Notifications
You must be signed in to change notification settings - Fork 860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify deploy_docs script to include Android #2258
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: Taner Topal <[email protected]>
Co-authored-by: Daniel J. Beutel <[email protected]>
Co-authored-by: Daniel J. Beutel <[email protected]>
Co-authored-by: Daniel J. Beutel <[email protected]>
…to add-android-sdk
on: | ||
pull_request |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on: | |
pull_request | |
on: | |
push: | |
branches: | |
- main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we always wants to deploy the docs on pull request?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right. We don't. I adjusted the suggestion.
Co-authored-by: Taner Topal <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we rename .github/workflows/android-release.yml
to .github/workflows/android.yml
?
In Android, we need a release that generates the artifacts and send it to maven central. Also ideally, after the release, the docs is built and deployed in our flower.dev website. What is the best way to achieve this? I don't think deploying the docs after a pull request is merged is suitable in this case. |
@danielnugraha, regarding the renaming of the CI YAML file, I just want to ensure that each team knows which YAML file belongs to their work. It could be clearer right now. Having just wrt to your comment about when to deploy the Android docs, you mentioned the following two options (correct me if I misread):
I am undecided. In the Python code base, we used to deploy on each push to merge and switched now to having versioned docs + latest docs. I am okay with deploying only on each release for Android. In the case of the iOS docs which we just merged, we deploy on each commit to @danieljanes any thoughts on this? |
Co-authored-by: Daniel J. Beutel <[email protected]>
Co-authored-by: Daniel J. Beutel <[email protected]>
I've changed the script name to android.yml, should I separate the publishing and deploying the docs? The publishing can be complicated if it triggers on every pull request merge. |
Issue
Description
The Android SDK doesn't have any API reference, so it's great to have one to soften the learning curve for users using our API.
Related issues/PRs
Proposal
Explanation
Build setup to generate API reference in html, basic styling to conform to Flower design guidelines and logo change are applied. Also the deploy_docs.sh is updated to generate android API reference. Changes base on Android SDK, merge only after Android SDK is merged.
Checklist
#contributions
)Any other comments?