Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify deploy_docs script to include Android #2258

Open
wants to merge 44 commits into
base: main
Choose a base branch
from

Conversation

danielnugraha
Copy link
Contributor

Issue

Description

The Android SDK doesn't have any API reference, so it's great to have one to soften the learning curve for users using our API.

Related issues/PRs

Proposal

Explanation

Build setup to generate API reference in html, basic styling to conform to Flower design guidelines and logo change are applied. Also the deploy_docs.sh is updated to generate android API reference. Changes base on Android SDK, merge only after Android SDK is merged.

Screenshot 2023-08-28 at 08 47 44 Screenshot 2023-08-28 at 08 48 24

Checklist

  • Implement proposed change
  • Write tests
  • Update documentation
  • Update changelog
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

Any other comments?

@danielnugraha danielnugraha changed the title Add deploy docs Modify deploy_docs script to include Android Aug 29, 2023
dev/deploy-docs.sh Outdated Show resolved Hide resolved
src/kotlin/.gitignore Outdated Show resolved Hide resolved
Comment on lines 3 to 4
on:
pull_request
Copy link
Member

@tanertopal tanertopal Aug 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
on:
pull_request
on:
push:
branches:
- main

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we always wants to deploy the docs on pull request?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. We don't. I adjusted the suggestion.

Copy link
Member

@tanertopal tanertopal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we rename .github/workflows/android-release.yml to .github/workflows/android.yml?

@danielnugraha
Copy link
Contributor Author

Can we rename .github/workflows/android-release.yml to .github/workflows/android.yml?

In Android, we need a release that generates the artifacts and send it to maven central. Also ideally, after the release, the docs is built and deployed in our flower.dev website. What is the best way to achieve this? I don't think deploying the docs after a pull request is merged is suitable in this case.

@tanertopal
Copy link
Member

tanertopal commented Aug 31, 2023

@danielnugraha, regarding the renaming of the CI YAML file, I just want to ensure that each team knows which YAML file belongs to their work. It could be clearer right now. Having just android.yml is, for me, as we have a mono repo, and the number of YAML files is getting out of control.

wrt to your comment about when to deploy the Android docs, you mentioned the following two options (correct me if I misread):

  1. Deploy on each commit to main
  2. Deploy on each release

I am undecided. In the Python code base, we used to deploy on each push to merge and switched now to having versioned docs + latest docs.

I am okay with deploying only on each release for Android. In the case of the iOS docs which we just merged, we deploy on each commit to main - although the swift release is in sync with that, right?

@danieljanes any thoughts on this?

@danielnugraha
Copy link
Contributor Author

@danielnugraha, regarding the renaming of the CI YAML file, I just want to ensure that each team knows which YAML file belongs to their work. It could be clearer right now. Having just android.yml is, for me, as we have a mono repo, and the number of YAML files is getting out of control.

wrt to your comment about when to deploy the Android docs, you mentioned the following two options (correct me if I misread):

1. Deploy on each commit to `main`

2. Deploy on each release

I am undecided. In the Python code base, we used to deploy on each push to merge and switched now to having versioned docs + latest docs.

I am okay with deploying only on each release for Android. In the case of the iOS docs which we just merged, we deploy on each commit to main - although the swift release is in sync with that, right?

@danieljanes any thoughts on this?

I've changed the script name to android.yml, should I separate the publishing and deploying the docs? The publishing can be complicated if it triggers on every pull request merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants