Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add client_fn argument to start_client #2303

Merged
merged 18 commits into from
Sep 12, 2023
Merged

Add client_fn argument to start_client #2303

merged 18 commits into from
Sep 12, 2023

Conversation

danieljanes
Copy link
Member

Issue

Description

Related issues/PRs

Proposal

Explanation

Checklist

  • Implement proposed change
  • Write tests
  • Update documentation
  • Update changelog
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

Any other comments?

@danieljanes danieljanes changed the title Add client_fn argument to start_server Add client_fn argument to start_client Sep 8, 2023
@jafermarq jafermarq marked this pull request as ready for review September 11, 2023 15:27
@jafermarq jafermarq mentioned this pull request Sep 11, 2023
Closed
danieljanes
danieljanes commented Sep 11, 2023
View reviewed changes
doc/source/ref-changelog.md Outdated Show resolved Hide resolved
src/py/flwr/client/app.py Outdated Show resolved Hide resolved
src/py/flwr/client/app.py Outdated Show resolved Hide resolved
src/py/flwr/client/app.py Outdated Show resolved Hide resolved
src/py/flwr/client/app.py Show resolved Hide resolved
src/py/flwr/client/app.py Show resolved Hide resolved
@jafermarq jafermarq marked this pull request as draft September 12, 2023 07:37
@jafermarq jafermarq marked this pull request as ready for review September 12, 2023 08:27
@jafermarq jafermarq mentioned this pull request Sep 12, 2023
Merged
@jafermarq
Copy link
Contributor

Merge #2349 first

@danieljanes danieljanes merged commit 7628028 into main Sep 12, 2023
26 checks passed
@danieljanes danieljanes deleted the client-fn-in-start-server branch September 12, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jafermarq jafermarq jafermarq left review comments

@tanertopal tanertopal tanertopal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danieljanes @jafermarq @tanertopal