Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Python 3.7 compatibility comment #2356

Merged
merged 7 commits into from
Sep 13, 2023
Merged

Remove Python 3.7 compatibility comment #2356

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
093eaaa
Remove Python 3.7 compatibility comment
danieljanes Sep 12, 2023
be22a4e
Merge branch 'main' into rm-37-compat
danieljanes Sep 13, 2023
019b7dd
Merge branch 'main' into rm-37-compat
danieljanes Sep 13, 2023
9d221ae
Merge branch 'main' into rm-37-compat
danieljanes Sep 13, 2023
0745d9e
Update changelog
danieljanes Sep 13, 2023
d2bae77
Merge branch 'main' into rm-37-compat
danieljanes Sep 13, 2023
af371b5
Merge branch 'main' into rm-37-compat
tanertopal Sep 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions doc/source/ref-changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,13 @@

- **General updates to the simulation engine** ([#2331](https:/adap/flower/pull/2331))

- **General improvements** ([#2309](https:/adap/flower/pull/2309), [#2310](https:/adap/flower/pull/2310), [2313](https:/adap/flower/pull/2313), [#2316](https:/adap/flower/pull/2316), [2317](https:/adap/flower/pull/2317),[#2349](https:/adap/flower/pull/2349))
- **General improvements** ([#2309](https:/adap/flower/pull/2309), [#2310](https:/adap/flower/pull/2310), [2313](https:/adap/flower/pull/2313), [#2316](https:/adap/flower/pull/2316), [#2317](https:/adap/flower/pull/2317),[#2349](https:/adap/flower/pull/2349))

Flower received many improvements under the hood, too many to list here.

### Incompatible changes

- **Remove support for Python 3.7** ([#2280](https:/adap/flower/pull/2280), [#2299](https:/adap/flower/pull/2299), [2304](https:/adap/flower/pull/2304), [#2306](https:/adap/flower/pull/2306), [2355](https:/adap/flower/pull/2355))
- **Remove support for Python 3.7** ([#2280](https:/adap/flower/pull/2280), [#2299](https:/adap/flower/pull/2299), [#2304](https:/adap/flower/pull/2304), [#2306](https:/adap/flower/pull/2306), [#2355](https:/adap/flower/pull/2355), [#2356](https:/adap/flower/pull/2356))

Python 3.7 support was deprecated in Flower 1.5, and this release removes support. Flower now requires Python 3.8.

Expand Down
5 changes: 0 additions & 5 deletions src/py/flwr/common/telemetry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,11 +164,6 @@ def _generate_next_value_(name: str, start: int, count: int, last_values: List[A
}


# In Python 3.7 pylint will throw an error stating that
# "Value 'Future' is unsubscriptable".
# This pylint disable line can be remove when dropping support
# for Python 3.7
# pylint: disable-next=unsubscriptable-object
def event(
event_type: EventType,
event_details: Optional[Dict[str, Any]] = None,
Expand Down