Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix default contiguous value in IidPartitioner #2406

Merged
merged 3 commits into from
Sep 22, 2023
Merged

Fix default contiguous value in IidPartitioner #2406

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dd7aa99
Fix default contiguous value in IidPartitioner
adam-narozniak Sep 21, 2023
5398784
Fix tests
adam-narozniak Sep 22, 2023
f9ea3be
Merge branch 'main' into fds-fix-default-contiguous
tanertopal Sep 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion datasets/flwr_datasets/partitioner/iid_partitioner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,5 +48,5 @@ def load_partition(self, idx: int) -> datasets.Dataset:
single dataset partition
"""
return self.dataset.shard(
num_shards=self._num_partitions, index=idx, contiguous=True
num_shards=self._num_partitions, index=idx, contiguous=False
)
12 changes: 9 additions & 3 deletions datasets/flwr_datasets/partitioner/iid_partitioner_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
import unittest
from typing import Tuple

import numpy as np
from parameterized import parameterized

from datasets import Dataset
Expand Down Expand Up @@ -100,11 +101,16 @@ def test_load_partition_correct_data(
self, num_partitions: int, num_rows: int
) -> None:
"""Test if the data in partition is equal to the expected."""
_, partitioner = _dummy_setup(num_partitions, num_rows)
partition_size = num_rows // num_partitions
dataset, partitioner = _dummy_setup(num_partitions, num_rows)
partition_index = 2
partition = partitioner.load_partition(partition_index)
self.assertEqual(partition["features"][0], partition_index * partition_size)
row_id = 0
self.assertEqual(
partition["features"][row_id],
dataset[np.arange(partition_index, len(dataset), num_partitions)][
"features"
][row_id],
)

@parameterized.expand( # type: ignore
[
Expand Down