Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update advanced-pytorch requirements #2471

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Update advanced-pytorch requirements #2471

merged 1 commit into from
Oct 6, 2023

Conversation

danielnugraha
Copy link
Contributor

@danielnugraha danielnugraha commented Oct 5, 2023 •
edited
Loading

Issue

Description

Pyproject.toml and requirements.txt in advanced-pytorch example is not synced.

Related issues/PRs

Proposal

Explanation

Sync pyproject.toml and requirements.txt in advanced-pytorch example by adding validators as dependency in requirements.txt

Checklist

  • Implement proposed change
  • Write tests
  • Update documentation
  • Update changelog
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

Any other comments?

@danielnugraha
Copy link
Contributor Author

Tested in python 3.8 and 3.10.

jafermarq
jafermarq approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@jafermarq jafermarq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

runs. LGM

@tanertopal tanertopal enabled auto-merge (squash) October 6, 2023 08:31
@tanertopal tanertopal merged commit f6ed52b into main Oct 6, 2023
26 checks passed
@tanertopal tanertopal deleted the update-advanced-pytorch-reqs branch October 6, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanertopal tanertopal tanertopal approved these changes

@jafermarq jafermarq jafermarq approved these changes

@danieljanes danieljanes Awaiting requested review from danieljanes danieljanes is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danielnugraha @tanertopal @jafermarq