feat(framework) Add SuperExec servicer #3606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieljanes
reviewed
Jun 14, 2024
danieljanes
reviewed
Jun 14, 2024
danieljanes
reviewed
Jun 14, 2024
danieljanes
reviewed
Jun 14, 2024
danieljanes
reviewed
Jun 14, 2024
danieljanes
reviewed
Jun 14, 2024
danieljanes
reviewed
Jun 14, 2024
danieljanes
reviewed
Jun 14, 2024
Comment on lines
46
to
48
| run = self.plugin.start_run(request.fab_file) | ||
| self.runs[run.run_id] = run.proc | ||
| return StartRunResponse(run_id=run.run_id) |
There was a problem hiding this comment.
Starting the run can fail. We should immediately start with error handling here.
There was a problem hiding this comment.
@danieljanes Should we make the run_id and proc of RunTracker optionals? Or should we make the return type of start_run optional? I think the second option is the most straightforward
There was a problem hiding this comment.
@danieljanes I updated it but do you think we should add an error field to the proto definition of the response?
danieljanes
reviewed
Jun 14, 2024
danieljanes
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Description
Related issues/PRs
Proposal
Explanation
Checklist
#contributions)Any other comments?