New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(framework) Allow `flower-server-app` to start with `run_id` #3658

Merged

danieljanes merged 45 commits into main from add-run-id-to-server-app-cli

Jun 21, 2024

Contributor

panh99 commented Jun 20, 2024

No description provided.

panh99 and others added 30 commits

June 11, 2024 13:21


add run proto

82a399a


implement getrun in driver_servicer and grpc_driver

019d490


Merge remote-tracking branch 'origin/impl-get-run-driver' into add-ru…

322440e

…n-id-to-server-app-cli


Merge branch 'main' into impl-get-run-driver

54b185a


Merge branch 'impl-get-run-driver' into add-run-id-to-server-app-cli

df79edb


Merge branch 'main' into impl-get-run-driver

e6cbede


Merge branch 'main' into impl-get-run-driver

bf3cd3b


Merge branch 'main' into impl-get-run-driver

5bc1c9c


amend driver class and in mem driver

7c82082


Merge branch 'main' into add-run-id-to-server-app-cli

20d66ea


add run_id arg

06d68dc


Merge branch 'main' into impl-get-run-driver

f9f8a10


Merge branch 'main' into impl-get-run-driver


update with main

6ef8ceb


fix the test for in mem driver

bf10f81


Merge branch 'main' into impl-get-run-driver

b57eeb7


Merge branch 'main' into impl-get-run-driver

0a09223


make run_id mandatory

5461e5d


Merge branch 'main' into impl-get-run-driver

77f8927


fix a bug in _init_run_id in simulation

dcc6cfd


format

dc03386


Merge remote-tracking branch 'origin/impl-get-run-driver' into add-ru…

c786e65

…n-id-to-server-app-cli


amend run_server_app

130435f


Merge remote-tracking branch 'origin/main' into add-run-id-to-server-…

b983714

…app-cli


restore

454722d


restore

0fea381


format


connect

df6502d


update run_serverapp

b197b2c


add sancheck

f45eac6

panh99 requested a review from tanertopal as a code owner

June 20, 2024 14:22


Merge branch 'main' into add-run-id-to-server-app-cli

30fb153

danieljanes reviewed

View reviewed changes

src/py/flwr/server/run_serverapp.py Outdated Show resolved Hide resolved


Update src/py/flwr/server/run_serverapp.py

62e85a0

danieljanes reviewed

View reviewed changes

src/py/flwr/server/run_serverapp.py Outdated Show resolved Hide resolved

danieljanes reviewed

View reviewed changes

src/py/flwr/server/run_serverapp.py Outdated Show resolved Hide resolved

danieljanes reviewed

View reviewed changes

src/py/flwr/server/run_serverapp.py Outdated Show resolved Hide resolved

danieljanes reviewed

View reviewed changes

src/py/flwr/server/run_serverapp.py Outdated Show resolved Hide resolved

danieljanes reviewed

View reviewed changes

src/py/flwr/server/run_serverapp.py Outdated Show resolved Hide resolved

panh99 added 4 commits

June 21, 2024 08:49


Merge remote-tracking branch 'origin/main' into add-run-id-to-server-…

13abfad

…app-cli


update based on comments

3d6a321


update exit message

fb485c6


update msg

25b9b1f

danieljanes reviewed

View reviewed changes

src/py/flwr/server/run_serverapp.py Show resolved Hide resolved

danieljanes reviewed

View reviewed changes

src/py/flwr/server/run_serverapp.py Outdated Show resolved Hide resolved

danieljanes reviewed

View reviewed changes

src/py/flwr/server/run_serverapp.py Show resolved Hide resolved

danieljanes reviewed

View reviewed changes

src/py/flwr/server/run_serverapp.py Show resolved Hide resolved


Apply suggestions from code review

e06c4dc

danieljanes reviewed

View reviewed changes

src/py/flwr/server/run_serverapp.py Outdated Show resolved Hide resolved


Update src/py/flwr/server/run_serverapp.py

e661d63

danieljanes reviewed

View reviewed changes

src/py/flwr/server/run_serverapp.py Outdated Show resolved Hide resolved


Update src/py/flwr/server/run_serverapp.py

9d97dbd

danieljanes reviewed

View reviewed changes

src/py/flwr/server/run_serverapp.py Show resolved Hide resolved

danieljanes previously approved these changes

View reviewed changes


Format

5601c05

danieljanes dismissed their stale review via

5601c05

June 21, 2024 09:12

danieljanes enabled auto-merge (squash)

June 21, 2024 09:13

danieljanes approved these changes

View reviewed changes

danieljanes merged commit a730466 into main

29 checks passed

danieljanes deleted the add-run-id-to-server-app-cli branch

June 21, 2024 11:37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment