Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(framework) Add Korean version #3680

Merged
merged 2 commits into from
Jun 25, 2024
Merged

docs(framework) Add Korean version #3680

merged 2 commits into from
Jun 25, 2024

Conversation

charlesbvll
Copy link
Member

Issue

Description

We have Korean translations but no button that redirects to it:

image

Related issues/PRs

N/A

Proposal

Explanation

Add button that redirects to the Korean version of the docs:

image

Checklist

  • Implement proposed change
  • Update documentation
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

Any other comments?

N/A

@tanertopal tanertopal enabled auto-merge (squash) June 25, 2024 10:58
Copy link
Member

@tanertopal tanertopal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@tanertopal tanertopal merged commit 7e80b91 into main Jun 25, 2024
29 checks passed
@tanertopal tanertopal deleted the add-korean-button branch June 25, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants