feat(framework) Introduce new client_fn signature passing the Context
#3779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieljanes
reviewed
Jul 12, 2024
src/py/flwr/client/client_app.py
Outdated
|
|
||
| if not all(key in client_fn_args for key in ["node_id", "partition_id"]): | ||
| if len(client_fn_args) != 1 or client_fn_args[first_arg].annotation is not Context: |
There was a problem hiding this comment.
The first arg might not have a Context annotation - we want users to allow def client_fn(context):, right?
Maybe we should just check the name: if the name is cid, or if it has a type annotation str, we use compat mode. Otherwise we assume Context.
There was a problem hiding this comment.
What should in the case where we have a type annotation, but it's neither str or Context?
danieljanes
reviewed
Jul 12, 2024
Co-authored-by: Daniel J. Beutel <[email protected]>
danieljanes
reviewed
Jul 12, 2024
danieljanes
reviewed
Jul 12, 2024
danieljanes
reviewed
Jul 12, 2024
danieljanes
reviewed
Jul 12, 2024
danieljanes
reviewed
Jul 12, 2024
danieljanes
reviewed
Jul 12, 2024
danieljanes
approved these changes
Jul 13, 2024
chongshenng
pushed a commit
that referenced
this pull request
Jul 16, 2024
…ext` (#3779) Co-authored-by: Daniel J. Beutel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update, again, the
client_fnsignature. Adjust the functions to support the previous signature (i.e.client_fn(cid: str)).Merge at some point after #3780