Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(framework) Remove partition_id from Context #3792

Merged
merged 2 commits into from
Jul 13, 2024

Conversation

jafermarq
Copy link
Contributor

@jafermarq jafermarq commented Jul 13, 2024

This PR:

  • Removes the partition_id from Context (this information can be embedded in the <Context>.node_confg)
  • Because of the above the NodeState class also removes the partition_id from its constructor.
  • In simulation, the node_config dict carries both partition-id and num-partitions keys
  • The above keys are now captured in flwr.common.constants to ease any further changes to these.
  • Some simulation tests were creating a Context obj directly. Now they instead create a NodeState object and use it to register & retrieve the context. No shortcuts.

@jafermarq jafermarq marked this pull request as ready for review July 13, 2024 08:22
@danieljanes danieljanes merged commit 48f223f into main Jul 13, 2024
28 checks passed
@danieljanes danieljanes deleted the remove-partition-id-from-context branch July 13, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants