Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(framework:skip) Remove FAB file once sent to SuperExec #3851

Merged
merged 5 commits into from
Aug 11, 2024
Merged

fix(framework:skip) Remove FAB file once sent to SuperExec #3851

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2f63904
fix(framework:skip) Remove FAB file once sent to SuperExec
charlesbvll Jul 18, 2024
3e28bd6
Merge branch 'main' into remove-fab-after-sending
charlesbvll Jul 18, 2024
3d4c44d
Merge branch 'main' into remove-fab-after-sending
charlesbvll Aug 8, 2024
fe7ee83
Merge branch 'main' into remove-fab-after-sending
charlesbvll Aug 11, 2024
3f70de5
Merge branch 'main' into remove-fab-after-sending
danieljanes Aug 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/py/flwr/cli/run/run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,10 +162,10 @@ def on_channel_state_change(channel_connectivity: str) -> None:
channel.subscribe(on_channel_state_change)
stub = ExecStub(channel)

fab_path = build(app)
fab_path = Path(build(app))

req = StartRunRequest(
fab_file=Path(fab_path).read_bytes(),
fab_file=fab_path.read_bytes(),
override_config=user_config_to_proto(
parse_config_args(config_overrides, separator=",")
),
Expand All @@ -174,6 +174,9 @@ def on_channel_state_change(channel_connectivity: str) -> None:
),
)
res = stub.StartRun(req)

# Delete FAB file once it has been sent to the SuperExec
fab_path.unlink()
typer.secho(f"🎊 Successfully started run {res.run_id}", fg=typer.colors.GREEN)


Expand Down