Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(framework) Add user config guide #3949

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

docs(framework) Add user config guide #3949

wants to merge 7 commits into from

Conversation

charlesbvll
Copy link
Member

Issue

Description

Related issues/PRs

Proposal

Explanation

Checklist

  • Implement proposed change
  • Write tests
  • Update documentation
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

Any other comments?

@charlesbvll charlesbvll changed the title Format rst docs(framework) Add user config guide Jul 31, 2024
jafermarq
jafermarq reviewed Aug 9, 2024
View reviewed changes
Copy link
Contributor

@jafermarq jafermarq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks pretty good. I wonder if we should point the reader to one of the quickstart examples (maybe a popular one that's not going to go away anytime soon, e.g. quickstart-pytorch or TF?

doc/source/how-to-configure-run.rst Show resolved Hide resolved
doc/source/how-to-configure-run.rst Show resolved Hide resolved
doc/source/how-to-configure-run.rst Outdated Show resolved Hide resolved
doc/source/how-to-configure-run.rst Show resolved Hide resolved
doc/source/how-to-configure-run.rst Outdated Show resolved Hide resolved
@charlesbvll charlesbvll marked this pull request as ready for review September 3, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jafermarq jafermarq jafermarq left review comments

@danieljanes danieljanes Awaiting requested review from danieljanes danieljanes is a code owner

@tanertopal tanertopal Awaiting requested review from tanertopal tanertopal is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charlesbvll @jafermarq