Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(framework:skip) Skip certain grpcio versions #3961

Merged
merged 3 commits into from
Aug 10, 2024
Merged

fix(framework:skip) Skip certain grpcio versions #3961

merged 3 commits into from
Aug 10, 2024

Conversation

chongshenng
Copy link
Contributor

@chongshenng chongshenng commented Aug 6, 2024 •
edited
Loading

Latest grpcio versions: 1.65.2 and 1.65.4 still contain unwanted log outputs:

WARNING: All log messages before absl::InitializeLog() is called are written to STDERR
I0000 00:00:1722952856.751538 3564221 fork_posix.cc:77] Other threads are currently calling into gRPC, skipping fork() handlers
I0000 00:00:1722952856.779549 3564221 fork_posix.cc:77] Other threads are currently calling into gRPC, skipping fork() handlers

@chongshenng chongshenng marked this pull request as ready for review August 6, 2024 14:06
@danieljanes danieljanes changed the title fix(framework:skip) Skip grpcio version fix(framework:skip) Skip certain grpcio versions Aug 10, 2024
@danieljanes danieljanes enabled auto-merge (squash) August 10, 2024 23:48
@danieljanes danieljanes merged commit 2005fe9 into main Aug 10, 2024
34 checks passed
@danieljanes danieljanes deleted the fix-grpcio-version branch August 10, 2024 23:52
chongshenng added a commit that referenced this pull request Aug 11, 2024
@chongshenng
fix(framework:skip) Skip certain grpcio versions (#3961)
2f19766
chongshenng added a commit that referenced this pull request Aug 13, 2024
@chongshenng
fix(framework:skip) Skip certain grpcio versions (#3961)
1d30bbd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieljanes danieljanes danieljanes approved these changes

@tanertopal tanertopal Awaiting requested review from tanertopal tanertopal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chongshenng @danieljanes