Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(*:skip) Update e2e tests directory structure #3981

Merged
merged 54 commits into from
Aug 16, 2024
Merged

Conversation

danielnugraha
Copy link
Contributor

Issue

Description

Related issues/PRs

Proposal

Explanation

Checklist

  • Implement proposed change
  • Write tests
  • Update documentation
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

Any other comments?

@danielnugraha danielnugraha changed the title Update e2e tests next ci(*:skip) Update e2e tests directory structure Aug 12, 2024
Copy link
Contributor

@panh99 panh99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we plan to make each E2E test a complete Flower App, could you:

  1. Rename the module name from, e.g., baree2e to e2e (or bare_e2e if you want)
  2. Change the subdir fields to e2e in .github/workflows/e2e.yml accordingly
  3. Update the [tool.flwr.app.components] section in all TOML files accordingly, e.g., changing baree2e.server_app:app to e2e.server_app:app.
  4. Update name fields in [project] section in all TOML files to give each E2E test a unique name, instead of just e2e_test, e.g., bare-e2e-test. (Btw, the app name cannot contain _, and thus please use - for app names instead.)

@danieljanes danieljanes enabled auto-merge (squash) August 16, 2024 11:39
@danieljanes danieljanes merged commit ac1cbff into main Aug 16, 2024
33 checks passed
@danieljanes danieljanes deleted the update-e2e-tests-next branch August 16, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants