Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(*:skip) Fix client interceptor tests #4047

Merged
merged 11 commits into from
Aug 20, 2024

Conversation

danielnugraha
Copy link
Contributor

Issue

Description

Client interceptor tests don't work because context manager captures all exceptions, making the pytests seems to pass.

Related issues/PRs

Proposal

Explanation

Fix client interceptor tests.

Checklist

  • Implement proposed change
  • Write tests
  • Update documentation
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

Any other comments?

@danieljanes danieljanes merged commit 9b58586 into main Aug 20, 2024
33 checks passed
@danieljanes danieljanes deleted the fix-client-interceptor-test branch August 20, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants