refactor(examples) Update fl-tabular example
#4053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohammadnaseri
requested review from
jafermarq,
tanertopal and
danieljanes
as code owners
jafermarq
reviewed
Aug 22, 2024
There was a problem hiding this comment.
@mohammadnaseri , looks pretty good. I made some suggestions to move a few lines of code around just so the flow is more similar to that in already-migrated quickstart examples (e.g. pytorch, tf, mlx). Let me know what you think!
jafermarq
approved these changes
Aug 23, 2024
jafermarq
changed the title
fl-tabular example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.