Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New: support for responsive menu item image sources (fixes #198) #200

Merged
merged 3 commits into from
Jul 15, 2024
Merged

New: support for responsive menu item image sources (fixes #198) #200

merged 3 commits into from
Jul 15, 2024

Commits on Jul 2, 2024

  1. use image template for menu item graphic 

    - set alt text as 'null' to prevent aria-label being applied to img. Maintain alt text reading in the menu item details instead.
    @kirsty-hames
    kirsty-hames committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    3f6fe37 View commit details
    Browse the repository at this point in the history

  2. remove attributionClassNamePrefixes 

    this only needs setting if different to classNamePrefixes
    @kirsty-hames
    kirsty-hames committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    668a4c8 View commit details
    Browse the repository at this point in the history

  3. exclude use of attribution 

    - attribution not currently supported in existing Boxmenu
- the reading order would render attribution before menu item title and image alt text which isn't logical
    @kirsty-hames
    kirsty-hames committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    4bc718b View commit details
    Browse the repository at this point in the history