Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can _graphic properties shared across plugins exist in a single schema instead of duplicating across plugin schemas? #563

Open
kirsty-hames opened this issue Jul 3, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@kirsty-hames
Copy link
Contributor

Subject of the issue

Currently _graphic properties are defined for each plugin schema e.g. src, alt and attribution. Can these exist in a single schema instead of duplicating across plugin schemas? e.g content schema.

Plugins using the jsx image template support all image properties but not all properties exist within the schema. For example, all images support multi device sources however schemas only support the initial sources the plugin was developed to support. GMCQ supports small and large, whilst Accordion only supports src.
If we wanted to support all image source properties within the AAT, we'd currently have to add them to each plugin schema. I'd be interested to hear peoples thoughts and ideas on this.

Relates to Menu item support for responsive image sources PR.

@joe-allen-89
Copy link
Contributor

Sounds like a good idea, keeps everything consistent and easy to manage with it being in one place. We currently $merge the schemas but presumably we could just $ref the image schema where needed.

@oliverfoster
Copy link
Member

There are instances where a single image schema would not fit. The image.jsx is a series of use-cases all bound together, it isn't necessary to use all of its features in every situation. Such as attribution in boxmenu. It may be that we need a couple/few variations of image.

@kirsty-hames
Copy link
Contributor Author

Thanks both and good point @oliverfoster that not all properties will apply to all instances/plugins.

It may be that we need a couple/few variations of image.

I'd be happy to look into this and report back...

@kirsty-hames kirsty-hames added enhancement New feature or request and removed question Further information is requested labels Jul 8, 2024
@kirsty-hames kirsty-hames self-assigned this Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

3 participants