Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue/3305 Support for alternative course folder name #138

Merged
merged 1 commit into from
Jun 21, 2022

Conversation

oliverfoster
Copy link
Member

@oliverfoster oliverfoster commented Jun 14, 2022

part of adaptlearning/adapt_framework#3305

Added

  • Support for course directory name to be received from grunt through the build.min.js file

Testing

  1. To change the folder from course to alternative and test out the code
git clone https:/adaptlearning/adapt_framework 3305-course
cd 3305-course
git checkout issue/3305
mv src/course src/alternative
adapt devinstall && npm install
cd src/core
git checkout issue/3305
cd ../../
grunt dev --coursedir=alternative
  1. You will need to find and replace all of the images in the json files from course/ to alternative/

@oliverfoster oliverfoster added the enhancement New feature or request label Jun 14, 2022
@oliverfoster oliverfoster self-assigned this Jun 14, 2022
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

Copy link
Contributor

@swashbuck swashbuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working fine. Images are loading from the correct locations. No web browser console or CLI errors.

@oliverfoster oliverfoster merged commit 43bf0e2 into master Jun 21, 2022
@oliverfoster oliverfoster deleted the issue/3305 branch June 21, 2022 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants