Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grunt server not automatically launching course on Windows #1227

Closed
moloko opened this issue Sep 6, 2016 · 9 comments
Closed

grunt server not automatically launching course on Windows #1227

moloko opened this issue Sep 6, 2016 · 9 comments

Comments

@moloko
Copy link
Contributor

moloko commented Sep 6, 2016

When you run the $ grunt server command the course does not automatically open in a browser on Windows (tested using Windows 10 with Firefox and Chrome as default browser). You can obviously open the course manually - but a novice user wouldn't know to do that, particularly as it's not clear what correct URL is.

Seems fine on OS X and Ubuntu

@moloko
Copy link
Contributor Author

moloko commented Sep 6, 2016

seems to be sporadic... not working for me or @lc-thomasberger but working for @tomgreenfield (Win 10, Firefox)

@finlayb
Copy link

finlayb commented Sep 7, 2016

Running Windows 10 and Chrome and this happens to me sometimes. Usually just run it a second time and it works.

@sarveshwar-gavhane
Copy link
Contributor

tested on windows 10 with Firefox and Chrome as default browser on two different machine's with 2.0.12 version it works fine on one machine and but not on another.

@NayanKhedkar
Copy link
Member

NayanKhedkar commented Sep 23, 2016

I have added 'open:true' in connect.js file as

module.exports = function (grunt, options) {

  var port = grunt.option('port') || 9001;

  return {
    server: {
      options: {
        port: port,
        base: '<%= outputdir %>',
        keepalive:true,
        open: true
      }
    },
    spoorOffline: {
      options: {
        port: port,
        base: '<%= outputdir %>',
        keepalive:true,
        open: true
      }
    }
  }
}

It worked for me.

@moloko
Copy link
Contributor Author

moloko commented Sep 29, 2016

@NayanKhedkar I just went to test this - only to find that it has started working again without me having changed anything, so I'm currently unable to verify whether these changes fix the problem or not!

I'll try again tomorrow

@NayanKhedkar
Copy link
Member

@moloko I tested it on windows 10 with IE11, Firefox and Chrome as default browser on various machines.
It worked well even on those machines on which it was not working properly previously.

@moloko
Copy link
Contributor Author

moloko commented Oct 10, 2016

Well I keep trying but still it is working normally for me.

However, I did notice that if I modified connect.js as detailed above I'd end up with two instances of the course being opened...

@sarveshwar-gavhane
Copy link
Contributor

sarveshwar-gavhane commented Nov 15, 2016

PR : #1317
is there any need to have open.js ? we can do it using connect.js by adding open : true but i'm not sure about spoor .

@moloko
Copy link
Contributor Author

moloko commented Jan 23, 2017

done in 39d2b8a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants