Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scrolling on mobile iOS triggering device:resize events #1561

Closed
brian-learningpool opened this issue May 15, 2017 · 0 comments
Closed

Scrolling on mobile iOS triggering device:resize events #1561

brian-learningpool opened this issue May 15, 2017 · 0 comments
Assignees
@brian-learningpool
Labels
bug

Comments

@brian-learningpool
Copy link
Member

I've noticed device:resize events being triggered when I scroll on iOS. For some reason iOS is detecting a scroll as a resize.

I'm seeing this on an iPhone 6s on 2.0.19.
@brian-learningpool brian-learningpool self-assigned this May 15, 2017
brian-learningpool added a commit that referenced this issue May 15, 2017
@brian-learningpool
Fixes #1561, corrects 'device:resize' on iOS devices
415783b 
Scroll events were triggering this due to the position of the address bar.  Given that the viewport size hasn't really changed this commit compares the height and width before and after the event, and only triggers device:resize if either have changed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brian-learningpool brian-learningpool

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brian-learningpool