Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib-tutor: Title not display title in feedback #1876

Closed
canstudios-louisem opened this issue Nov 23, 2017 · 11 comments
Closed

contrib-tutor: Title not display title in feedback #1876

canstudios-louisem opened this issue Nov 23, 2017 · 11 comments
Assignees

Comments

@canstudios-louisem
Copy link

Tutor is showing the components title not display title in the feedback notify.

@chetan-hajare chetan-hajare self-assigned this Dec 8, 2017
@chetan-hajare
Copy link

Hi @canstudios-louisem
We are using the title in the feedback since the beginning of the development of the Adapt framework. The page level progress extension also uses title to represent component in the drawer. If we think to change the feedback title to display title, we might have to consider the page level progress extension too. @brian-learningpool @moloko @oliverfoster @lc-thomasberger Can you please provide your suggestions on this?

@oliverfoster
Copy link
Member

oliverfoster commented Dec 8, 2017

i think the feedback should be able to specify a title and any additional properties for each feedback item to pass off to tutor.

@oliverfoster
Copy link
Member

need to expand this object to take titles, body text, images etc
https:/adaptlearning/adapt_framework/blob/master/src/course/en/components.json#L424

@tomgreenfield
Copy link
Contributor

Related: #1734.

@lc-thomasberger
Copy link
Member

For PageLevelProgress it is actually good to use title instead of displayTitle (long titles do not work with Drawer), so I think we should stick with this behavior.
For questions a separate title field would be nice. It should default to the component's title if it is not specified.

@canstudios-louisem
Copy link
Author

Being able to set the feedback's notify title would fix this issue for us really. Most of the time we just want it to say Feedback or similar.

@oliverfoster
Copy link
Member

@canstudios-louisem one for _partlyCorrect, corract and incorrect? Or just a general title per component?

@chetan-hajare
Copy link

I would prefer a general title per component. What do you think about this @canstudios-louisem ?

@chetan-hajare
Copy link

PR: #1954

@canstudios-louisem
Copy link
Author

Thanks for your work on this @chetan-hajare much appreciated 👍

@moloko
Copy link
Contributor

moloko commented Mar 29, 2018

should all be done now that adaptlearning/adapt-contrib-mcq#139 is in.

@moloko moloko closed this as completed Mar 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants