Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update modernizr #1934

Closed
oliverfoster opened this issue Jan 23, 2018 · 0 comments
Closed

Update modernizr #1934

oliverfoster opened this issue Jan 23, 2018 · 0 comments
Assignees
Milestone

Comments

@oliverfoster
Copy link
Member

oliverfoster commented Jan 23, 2018

Subject of the issue/enhancement/features

Modernizr needs updating as the our version is 2.8.3 and the current stable is 3.5.0

Problems

Modernizr.load API has been retired and so needs replacing in the scriptLoader.js
Modernizr.touch identification API has changed slightly and needs to be made backwards compatible.

Needed Outcomes

Retrofit Modernizr.touchevents to Modernizr.touch + classes
Replace Modernizr.load with loadScript functionality in scriptLoader.js
Implement Adapt.loadScript API with callback as a replacement to Modernizr.load
Remove Modernizr checks which are for <IE11 browsers
Switch to using no-touchevents and touchevents in core
Switch core to use Adapt.device.touch rather than Modernizr.touch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants