-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Schema defaults not being produced #2248
Labels
Comments
could you include Steps to reproduce/Expected behaviour/Actual Behaviour? makes it a lot easier to test the fix if it's crystal clear what the original issue is |
Hows that? ;) |
oliverfoster
added a commit
that referenced
this issue
Nov 1, 2018
oliverfoster
added a commit
that referenced
this issue
Nov 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Subject of the issue
The
schema-defaults
grunt task reads and writes course.json from the source folder (src/course/en/course.json) to the output folder (builds/en/course.json) at these lines. Thecopy
grunt task reads course.json from the source folder and overwrites the course.json in the output folder at these lines. Thecopy
grunt task is run after theschema-defaults
grunt task in both thedev
grunt task and thebuild
grunt task.The
copy
grunt task overwrites any changes made by theschema-defaults
grunt task.Your environment
Steps to reproduce
Expected behaviour
_globals
object should be populated with missing properties schema attributes.Actual behaviour
"popupPagination"
aria label should appear in course.json at_globals._components._hotgraphic.popupPagination
, having not been included in the currently available course.json but being listed in the current hotgraphic schema.Screenshots (if you can)
The text was updated successfully, but these errors were encountered: