Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema defaults not being produced #2248

Closed
oliverfoster opened this issue Nov 1, 2018 · 2 comments
Closed

Schema defaults not being produced #2248

oliverfoster opened this issue Nov 1, 2018 · 2 comments
Assignees
Labels

Comments

@oliverfoster
Copy link
Member

oliverfoster commented Nov 1, 2018

Subject of the issue

The schema-defaults grunt task reads and writes course.json from the source folder (src/course/en/course.json) to the output folder (builds/en/course.json) at these lines. The copy grunt task reads course.json from the source folder and overwrites the course.json in the output folder at these lines. The copy grunt task is run after the schema-defaults grunt task in both the dev grunt task and the build grunt task.
The copy grunt task overwrites any changes made by the schema-defaults grunt task.

Your environment

  • Current master framework with current master plugins
  • Google Chrome
  • PC, Windows 10

Steps to reproduce

  1. Download and install Adapt Framework
  2. Run grunt dev

Expected behaviour

  1. The build/en/course.json _globals object should be populated with missing properties schema attributes.

Actual behaviour

  1. Hotgraphic's new "popupPagination" aria label should appear in course.json at _globals._components._hotgraphic.popupPagination, having not been included in the currently available course.json but being listed in the current hotgraphic schema.

Screenshots (if you can)

image
image

@moloko
Copy link
Contributor

moloko commented Nov 1, 2018

could you include Steps to reproduce/Expected behaviour/Actual Behaviour? makes it a lot easier to test the fix if it's crystal clear what the original issue is

@oliverfoster
Copy link
Member Author

Hows that? ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants