Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect "Unknown" lesson status when completing assessment and course in different attempts #2398

Closed
brian-learningpool opened this issue Mar 26, 2019 · 1 comment
Closed

Incorrect "Unknown" lesson status when completing assessment and course in different attempts #2398

brian-learningpool opened this issue Mar 26, 2019 · 1 comment
Labels
bug high priority

Comments

@brian-learningpool
Copy link
Member

Subject of the issue

Reported by @muthuselvan86 on Gitter. If a course has an assessment and course content tracked as part of the completion criteria, in instances where the assessment is completed first, the session closed and then resumed, when the rest of the course content is completed the lesson status is incorrectly showing as "Unknown".

Your environment

  • Adapt Framework v3/4

Steps to reproduce

As above.

Expected behaviour

A "Completed" status would be written to the LMS.

Actual behaviour

An "Unknown" status is being written because the assessment is not found.
@muthuselvan86
Copy link
Contributor

muthuselvan86 commented Mar 27, 2019 •
edited
Loading

Hi @brian-learningpool , @moloko ,

Please consider this scenario as well, lets say when a user directly try(without completing the lessons) the assessment and got "failed" and in another session if he completes all lesson the success status shows "Unknown" Ideally it should be "Failed". I doubt this bug could be happening on tracking.js but i just started checking.

@moloko - Does this scenario is a real issue for on-prem systems?

muthuselvan86 pushed a commit to muthuselvan86/adapt_framework that referenced this issue Mar 28, 2019
issue/adaptlearning#2398 - Incorrect Unknown lesson status when compl…
c8bafd7 
…eting assessment first
muthuselvan86 pushed a commit to muthuselvan86/adapt_framework that referenced this issue Mar 28, 2019
issue/adaptlearning#2398 - Fixed quotes issue
85080e4
brian-learningpool added a commit that referenced this issue Apr 3, 2019
@brian-learningpool
Resolves #2398, re-populates _assessmentState from 'assessments:regis…
cc1c8c5 
…ter'

This corrects an issue with incorrect course completion statuses being passed back
when a course was being completed over multiple sessions.
brian-learningpool added a commit that referenced this issue Apr 3, 2019
@brian-learningpool
Resolves #2398, re-populates _assessmentState from 'assessments:regis…
feb7635 
…ter'

This corrects an issue with incorrect course completion statuses being passed back
when a course was being completed over multiple sessions.
brian-learningpool added a commit that referenced this issue Apr 3, 2019
@brian-learningpool
Resolves #2398, re-populates _assessmentState from 'assessments:regis…
d135086 
…ter' (#2402)

This corrects an issue with incorrect course completion statuses being passed back
when a course was being completed over multiple sessions.
brian-learningpool added a commit that referenced this issue Apr 4, 2019
@brian-learningpool
Issue/2398 v3 (#2404)
dfaa6f5 
* Resolves #2398, re-populates _assessmentState from 'assessments:register'

This corrects an issue with incorrect course completion statuses being passed back
when a course was being completed over multiple sessions.

* Added listener for 'assessment:restored' event to tracking.js

This event is raised by Assessment v3.0.2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug high priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brian-learningpool @muthuselvan86